Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issue with venv #17708

Closed
wants to merge 29 commits into from
Closed

Fix CI issue with venv #17708

wants to merge 29 commits into from

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 12, 2021 •
edited by karrtikr
Loading

For #17666

@karthiknadig
Ensure extension is activated.
bbdf483
@karthiknadig
Check extension activation.
8d3ab58
@karthiknadig
Use proposed API to seeif activation occurs.
28ec5ed
@karthiknadig
Ensure Python set for testing is same as the one we set.
d5b54d8
@karthiknadig
Add wait for the settings to propagate.
d1c2c89
@karthiknadig
Ensure we wait long enough for settings to propagate
8bdbf4d
@karthiknadig
Ensure settings are propagated.
b9f22fa
@karthiknadig
Change settings till it is applied.
08c4ebf
@karthiknadig
Wait for settings to propagate for much longer.
afd6d94
@karthiknadig
Remove settings debounce
80da5d1
@karthiknadig
Ensure global settings are updated during tests
abcd6f5
@karthiknadig
More minor tweaks
4a103d2
@karthiknadig
Ensue config change event is fired on vscode.
c73abce
@karthiknadig
More tweaks
747d2ee
@karthiknadig
Ensure we set the on changed event correctly.
2643d00
@karthiknadig
Try again.
f06504d
@karthiknadig
Try with additional logging
4a1a8e2
@karthiknadig
More logs
fb5181a
@karthiknadig
Try setting both values.
3a9c87e
@karthiknadig
More logging
4f8845e
@karthiknadig
More logs
cb7ad60
@karthiknadig
Even More logs
b4040be
@karthiknadig
Log activation command provider
1cd6951
@karthiknadig
Try forcing interpreter details
eb06661
@karrtikr karrtikr self-assigned this Oct 13, 2021
@karrtikr karrtikr mentioned this pull request Oct 14, 2021
Closed
@karthiknadig karthiknadig deleted the terminal-activation branch November 4, 2021 05:04
@karthiknadig karthiknadig restored the terminal-activation branch November 4, 2021 05:04
@karthiknadig karthiknadig deleted the terminal-activation branch December 8, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@karthiknadig karthiknadig

@karrtikr karrtikr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karthiknadig @karrtikr